Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zce LLVM (for prototype) #4

Open
1 of 13 tasks
jjscheel opened this issue Mar 16, 2023 · 47 comments
Open
1 of 13 tasks

Zce LLVM (for prototype) #4

jjscheel opened this issue Mar 16, 2023 · 47 comments
Assignees

Comments

@jjscheel
Copy link
Contributor

jjscheel commented Mar 16, 2023

Technical Group

Code Size Reduction TG

ratification-pkg

Code Size

Technical Liaison

Tariq Kurd

Task Category

Compilers/Toolchain

Task Sub Category

  • gcc
  • binutils
  • gdb
  • intrinsics
  • Java
  • KVM
  • ld
  • llvm
  • Linux kernel
  • QEMU
  • Spike

Ratification Target

1Q2023

Statement of Work (SOW)

SOW link

SOW Signoffs: (delete those not needed)

  • Task group liaison sign-off date:
  • Development partner sign-off date:
  • Toolchains & Runtimes sign-off date (if gcc, LLVM, binutils, gdb work):

Waiver

  • Freeze
  • Ratification

Pull Request Details

  1. Zcmp 1 - merged
  2. Zcmp 2 - merged
  3. Zcmp 3 - merged
  4. Zcmp 4 - merged
  5. Zcmt 1 - merged
  6. Zcmt 2 - merged
  7. lld patch - open
@jjscheel
Copy link
Contributor Author

Patches remain in review per 3/28 meeting. No action needed.

@jjscheel
Copy link
Contributor Author

@lazyparser, would you kindly help me get this assigned to Chunyu?

@jjscheel jjscheel assigned lazyparser and unassigned jjscheel Apr 11, 2023
@ChunyuLiao
Copy link

GitHub ID: ChunyuLiao, You can assign it to me, sorry for the late reply.

@jjscheel
Copy link
Contributor Author

Thanks, @ChunyuLiao. Would you kindly also make sure that you've added it to your RISC-V Profile in the GitHub id field. Details are here: link

Also, if you're not a member of the DevPartners community, please join.

@jjscheel
Copy link
Contributor Author

@ChunyuLiao, nevermind. I see that you've already done this. THANKS!!!

@jjscheel jjscheel self-assigned this Apr 11, 2023
@ChunyuLiao
Copy link

@jjscheel jjscheel assigned ChunyuLiao and unassigned jjscheel and lazyparser Apr 11, 2023
@jjscheel
Copy link
Contributor Author

Thanks, @ChunyuLiao! I've bumped the projected completion date to next meeting, April 25.

@jjscheel
Copy link
Contributor Author

jjscheel commented May 1, 2023

Based on last week's discussion that reviews are still pending, I've bumped the Completion Projection date to next meeting (May 9) to match Next Status date.

@ChunyuLiao
Copy link

[RISCV] Add MC support of RISCV zcmt Extension https://reviews.llvm.org/D134600 has been merged

@jjscheel
Copy link
Contributor Author

jjscheel commented May 8, 2023

Thanks, @ChunyuLiao! Great news!!! 1 down 3 to go.

@jjscheel
Copy link
Contributor Author

jjscheel commented May 8, 2023

Removed from Agenda for this week.

@Xinlong-Wu
Copy link

[RISCV] Add MC support of RISCV zcmp Extension https://reviews.llvm.org/D132819 has been merged

@jjscheel
Copy link
Contributor Author

jjscheel commented May 9, 2023

Way to go! Just 2 more!!!

@ChunyuLiao
Copy link

ChunyuLiao commented May 23, 2023

@jjscheel
Copy link
Contributor Author

Done. Thank you, @ChunyuLiao!

@ChunyuLiao
Copy link

Zcmp have been updated. Need to sync-up two weeks later :)

@ChunyuLiao
Copy link

All Zcmp patchs have been merged.

@jjscheel
Copy link
Contributor Author

Marking as done. Thanks, @ChunyuLiao! Nice work!!!

@ChunyuLiao
Copy link

Sorry Jeff. There is only one zcmt not merged and it is the 6th patch https://reviews.llvm.org/D134600.

@ChunyuLiao
Copy link

Thanks, @ChunyuLiao. Have you received any feedback on your latest patch?

No feedback. I'm guessing there won't be any feedback for the next month.

@jrtc27
Copy link

jrtc27 commented Oct 10, 2023

Your last update on the patch was 7th September. If you want people to review it you should ping the patch (adhering to https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity) and possibly them specifically, otherwise it drops off their radar.

@ChunyuLiao
Copy link

ChunyuLiao commented Oct 10, 2023

Your last update on the patch was 7th September. If you want people to review it you should ping the patch (adhering to https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity) and possibly them specifically, otherwise it drops off their radar.

Thanks, we're looking forward to your suggestions!

@ChunyuLiao
Copy link

No update for the last two weeks. thanks.

@ChunyuLiao
Copy link

The lld patch was just updated today

@ChunyuLiao
Copy link

Waiting for re-review.
We've done some testing and the results have been added to the comments, hope it helps.

@Xinlong-Wu
Copy link

Still in reviewing
Since the reviews.llvm.org has been turn to static, the patch is hard to be access and review patch.
So we are trying to move it to github PR.

@ChunyuLiao
Copy link

new pr: llvm/llvm-project#77884

@jjscheel
Copy link
Contributor Author

Thanks, @ChunyuLiao. Added to the list in header.

@ChunyuLiao
Copy link

No new updates for the last 3 weeks.

@ChunyuLiao
Copy link

No updates for the last 2 weeks.

@ChunyuLiao
Copy link

Do more discussions and updated zcmt last week.

@ChunyuLiao
Copy link

no update.

@Xinlong-Wu
Copy link

No more update

@jjscheel
Copy link
Contributor Author

@Xinlong-Wu, @ChunyuLiao, anything we can do to encourage review of the PR?
@cmuellner, are you aware of this PR and any problems here?

@Xinlong-Wu
Copy link

no update for pervious weeks.

currently, the reviewers are concerned about the efficiency(how much reduction we can get by current implementation) of zcmt can do.

It related to the linking time, so the reviewers would be very strict

@Xinlong-Wu
Copy link

no update

@Xinlong-Wu
Copy link

no more update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: As-planned
Development

No branches or pull requests

6 participants