Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review WasmI32AtomicWait32Descriptor::InitializePlatformSpecific #424

Open
ghost opened this issue Feb 5, 2021 · 0 comments
Open

Review WasmI32AtomicWait32Descriptor::InitializePlatformSpecific #424

ghost opened this issue Feb 5, 2021 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@ghost
Copy link

ghost commented Feb 5, 2021

After atomics are implemented, this RISC-V specific code in interface-descriptors.cc needs to be reviewed:

#if !defined(V8_TARGET_ARCH_MIPS) && !defined(V8_TARGET_ARCH_MIPS64) && \
    !defined(V8_TARGET_ARCH_RISCV64)
void WasmI32AtomicWait32Descriptor::InitializePlatformSpecific(
    CallInterfaceDescriptorData* data) {
  DefaultInitializePlatformSpecific(data, kParameterCount);
}

void WasmI64AtomicWait32Descriptor::InitializePlatformSpecific(
    CallInterfaceDescriptorData* data) {
  DefaultInitializePlatformSpecific(data,
                                    kParameterCount - kStackArgumentsCount);
}
#endif
@ghost ghost added the question Further information is requested label Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant