Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace memory read in simulator for amo #430

Open
ghost opened this issue Feb 5, 2021 · 1 comment
Open

Trace memory read in simulator for amo #430

ghost opened this issue Feb 5, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 5, 2021

simulator-riscv64.h:437:

  template <typename T, typename OP>
  T amo(int64_t addr, OP f, Instruction* instr, TraceType t) {
    auto lhs = ReadMem<T>(addr, instr);
    // TODO(RISCV): trace memory read for AMO
    WriteMem<T>(addr, (T)f(lhs), instr);
    return lhs;
  }
@ghost ghost added the enhancement New feature or request label Feb 5, 2021
@lazyparser
Copy link
Collaborator

@qjivy please find out whether this issue is still relevant or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants