Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new argument to ensure the result is correct for vslideup and vslidedown #32

Closed
monkchiang opened this issue Jul 24, 2020 · 2 comments

Comments

@monkchiang
Copy link
Collaborator

All of vslideup and vslidedown have an issue.  

For example, the vslideup.vx operation is vd[i + rs1] = vs2[i].
So We don't know Vd's value from vd[i] to vd[i + rs1].
If we want to know all of vd's value, then we need to insert a argumenet,
to initial Vd value. Thus, I suggest to add a new argument for initial Vd value.

vint8m1_t vslideup_vx_i8m1 (vint8m1_t src, size_t offset);

change to

vint8m1_t vslideup_vx_i8m1 (vint8m1 dst, vint8m1_t src, size_t offset);

@kito-cheng
Copy link
Collaborator

This issue is similar to #25 , so I think it's reasonable changes, @rofirrim any comment?

@rofirrim
Copy link
Collaborator

I agree. I think it makes sense to be able able to reliably know what is going to be in the unchanged elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants