New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example DTS for the HiFive Unleashed #8
Conversation
This is the device tree that's shipped on the HiFive Unleashed, where it lives inside the FSBL (which is in a SPI flash). As that's the only currently availiable RISC-V Linux board it should serve as a good reference for people who want to poke around in device tree land. This device tree contains entries that coorespond to devices on the MicroSemi expansion board. Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. (But note that I'm not a real devicetree expert — those are on the devicetree@vger.kernel.org mailing list)
sifive,fsbl = "YYYY-MM-DD"; | ||
}; | ||
|
||
L3: cpus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The labels are a bit meaningless (but still better than explicit phandles :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, I agree. They're auto-generated, though, and I'm afraid I won't have time to make something prettier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who adds the phandles then ? Especially for interrupt-controller.
bbl expects a phandle in during query hart.
L2: soc { | ||
#address-cells = <2>; | ||
#size-cells = <2>; | ||
compatible = "SiFive,FU540G-soc", "fu500-soc", "sifive-soc", "simple-bus"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/SiFive,/sifive,/ perhaps; it's spelled lowercase elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we mix these all over the place. We should clean it up when these actually land as a spec.
@neuschaefer Thanks. This is more of a way to answer the common question of "what is the HiFive Unleashed's device tree" than a stamp of approval. We'll still get every binding properly reviewed and then update this accordingly. |
This is the device tree that's shipped on the HiFive Unleashed, where it
lives inside the FSBL (which is in a SPI flash). As that's the only
currently availiable RISC-V Linux board it should serve as a good
reference for people who want to poke around in device tree land.
This device tree contains entries that coorespond to devices on the
MicroSemi expansion board.
Signed-off-by: Palmer Dabbelt palmer@sifive.com