Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target/riscv: set some csr size to 32 #830

Merged
merged 1 commit into from
Apr 6, 2023
Merged

target/riscv: set some csr size to 32 #830

merged 1 commit into from
Apr 6, 2023

Conversation

zqb-all
Copy link
Contributor

@zqb-all zqb-all commented Apr 3, 2023

Change-Id: I4703b7b8ad492b14dc8d188ebb8f645c568fd515

@zqb-all
target/riscv: set some csr size to 32
e284aa0 
Change-Id: I4703b7b8ad492b14dc8d188ebb8f645c568fd515
Signed-off-by: Mark Zhuang <mark.zhuang@spacemit.com>
@zqb-all
Copy link
Contributor Author

zqb-all commented Apr 5, 2023

Without this patch, my openocd will try to write dcsr with size 64 and fail, then show log: "Disableing abstract command write to CSRs"

timsifive
timsifive approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@timsifive timsifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. I suspect you're the first person really using an implementation where abstract commands are used for CSRs.

@timsifive timsifive merged commit 52b1023 into riscv-collab:riscv Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsifive timsifive timsifive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zqb-all @timsifive