Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API with alloy_rpc_types instead of revm_primitives #62

Closed
hai-rise opened this issue May 13, 2024 · 3 comments · Fixed by #147
Closed

Add API with alloy_rpc_types instead of revm_primitives #62

hai-rise opened this issue May 13, 2024 · 3 comments · Fixed by #147
Assignees
Labels
enhancement New feature or request V1

Comments

@hai-rise
Copy link
Contributor

hai-rise commented May 13, 2024

While the latter is still useful for tests, ideally we would only have API with alloy_rpc_types which:

  • Is much better for integration. For Reth, our REVM fork's types conflict with theirs, while alloy_rpc_types is the future anyway.
  • Abstracts the underlying executor away, so the interface stays the same when we introduce JIT & AOT executors, etc.
@hai-rise hai-rise added enhancement New feature or request V1 labels May 13, 2024
@hai-rise
Copy link
Contributor Author

Done for now in #65.

@hai-rise
Copy link
Contributor Author

We still need to replace REVM types with Alloy's in the output.

@hai-rise
Copy link
Contributor Author

hai-rise commented Jun 9, 2024

The remaining work is narrowed down to this!

pevm/src/pevm.rs

Lines 54 to 55 in ae18f9e

// TODO: Use our own type to not leak REVM types to library users.
pub state: EvmState,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request V1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants