Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: select compaction strategy using statistics #638

Closed
skyzh opened this issue Apr 24, 2022 · 4 comments · Fixed by #689
Closed

storage: select compaction strategy using statistics #638

skyzh opened this issue Apr 24, 2022 · 4 comments · Fixed by #689
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@skyzh
Copy link
Member

skyzh commented Apr 24, 2022

If we find distinct value statistics is very small compared with row counts, we can use RLE encoding when building RowSets.

let mut builder = RowsetBuilder::new(
table.columns.clone(),
ColumnBuilderOptions::from_storage_options(&table.storage_options),
);

@skyzh skyzh added the good first issue Good for newcomers label Apr 24, 2022
@jess-x
Copy link

jess-x commented Apr 27, 2022

newbie here, can I give this a try?

@skyzh skyzh added the enhancement New feature or request label Apr 28, 2022
@noneback
Copy link
Contributor

Any progress? I am also very interested in it.

@skyzh
Copy link
Member Author

skyzh commented Jun 14, 2022

Hmm, maybe you can take over this as it has been nearly a month that we haven't heard back from @jess-x 🤣

@jess-x
Copy link

jess-x commented Jun 14, 2022

hi, feel free to take over. didn't have the bandwidth this past month 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants