Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: header seems to be None all the time #817

Closed
caicancai opened this issue Dec 2, 2023 · 2 comments · Fixed by #818
Closed

bug: header seems to be None all the time #817

caicancai opened this issue Dec 2, 2023 · 2 comments · Fixed by #818

Comments

@caicancai
Copy link
Contributor

caicancai commented Dec 2, 2023 •
edited
Loading

2023-12-02 22-27-39屏幕截图

The header seems to be None all the time and will not enter the header judgment logic in the picture.
@caicancai caicancai changed the title perf: optimize output bug: header seems to be None all the time Dec 2, 2023
@caicancai caicancai changed the title bug: header seems to be None all the time Bug: header seems to be None all the time Dec 2, 2023
@caicancai caicancai changed the title Bug: header seems to be None all the time bug: header seems to be None all the time Dec 2, 2023
@caicancai
Copy link
Contributor Author

I'll try to fix him

@caicancai caicancai mentioned this issue Dec 3, 2023
Merged
@wangrunji0408
Copy link
Member

wangrunji0408 commented Dec 3, 2023 •
edited
Loading

This method was used in query engine v1, but was not migrated during the refactor. Thanks for your effort to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat/header: support set chunk header caicancai/risinglight
2 participants
@wangrunji0408 @caicancai