Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash dependency #16

Closed
gyzerok opened this issue Jul 29, 2015 · 7 comments
Closed

Remove lodash dependency #16

gyzerok opened this issue Jul 29, 2015 · 7 comments
Labels

Comments

@gyzerok
Copy link
Contributor

gyzerok commented Jul 29, 2015

What do you think about removing lodash?

@hekike
Copy link
Contributor

hekike commented Jul 29, 2015

@gyzerok I don't understand this question. From where do you get it?

@hekike
Copy link
Contributor

hekike commented Jul 29, 2015

Ok I understand now, so you want to remove it.

Why? Do you think it's a good idea?

@gyzerok
Copy link
Contributor Author

gyzerok commented Jul 29, 2015

@hekike I am now sure, but isnt it better to have as minimal dependency list as possible? It looks like you use just a few lodash functions in your code.

@hekike
Copy link
Contributor

hekike commented Jul 29, 2015

@gyzerok yes it's good to keep it on minimum but I'm iterating over Objects instead of Arrays and in thnk lodash is doing it well. If we want to optimise it then in lodash it's possible to require only the specific functions and decrease the bundled code size. I think it would be a better strep.

@hekike
Copy link
Contributor

hekike commented Jul 30, 2015

@gyzerok maybe turning or mapish Object -s to ES6 Map etc. would help us to use for of and other ES6 features with babel and would make it possible. I will investigate it later.

@gyzerok
Copy link
Contributor Author

gyzerok commented Jul 30, 2015

@hekike suppose its better use more functional approach. for of is an imperative one :)

@hekike
Copy link
Contributor

hekike commented Jul 30, 2015

Ok then I close this issue.

@hekike hekike closed this as completed Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants