-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install failed when setting harbor secrets #17
Comments
diff --git a/charts/risingwave/templates/compactor-deploy.yaml b/charts/risingwave/templates/compactor-deploy.yaml
index ad186d6..c46bd26 100644
--- a/charts/risingwave/templates/compactor-deploy.yaml
+++ b/charts/risingwave/templates/compactor-deploy.yaml
@@ -46,7 +46,7 @@ spec:
{{- if .Values.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.image.pullSecrets }}
- - {{ . }}
+ - name: {{ . }}
{{- end }}
{{- end }}
volumes:
diff --git a/charts/risingwave/templates/compute-sts.yaml b/charts/risingwave/templates/compute-sts.yaml
index 2e34e0d..afbf9d2 100644
--- a/charts/risingwave/templates/compute-sts.yaml
+++ b/charts/risingwave/templates/compute-sts.yaml
@@ -50,7 +50,7 @@ spec:
{{- if .Values.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.image.pullSecrets }}
- - {{ . }}
+ - name: {{ . }}
{{- end }}
{{- end }}
volumes:
diff --git a/charts/risingwave/templates/frontend-deploy.yaml b/charts/risingwave/templates/frontend-deploy.yaml
index c42c7e8..707820f 100644
--- a/charts/risingwave/templates/frontend-deploy.yaml
+++ b/charts/risingwave/templates/frontend-deploy.yaml
@@ -47,7 +47,7 @@ spec:
{{- if .Values.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.image.pullSecrets }}
- - {{ . }}
+ - name: {{ . }}
{{- end }}
{{- end }}
volumes:
diff --git a/charts/risingwave/templates/meta-sts.yaml b/charts/risingwave/templates/meta-sts.yaml
index 1932d06..b787aa2 100644
--- a/charts/risingwave/templates/meta-sts.yaml
+++ b/charts/risingwave/templates/meta-sts.yaml
@@ -50,7 +50,7 @@ spec:
{{- if .Values.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.image.pullSecrets }}
- - {{ . }}
+ - name: {{ . }}
{{- end }}
{{- end }}
volumes:
diff --git a/charts/risingwave/templates/standalone/standalone-sts.yaml b/charts/risingwave/templates/standalone/standalone-sts.yaml
index 9e0345a..597a57e 100644
--- a/charts/risingwave/templates/standalone/standalone-sts.yaml
+++ b/charts/risingwave/templates/standalone/standalone-sts.yaml
@@ -47,7 +47,7 @@ spec:
{{- if .Values.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.image.pullSecrets }}
- - {{ . }}
+ - name: {{ . }}
{{- end }}
{{- end }}
volumes:
|
Thanks for reporting the issue. You're right. Let me fix it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using harbor secrets, it will failed with the following messages:
Maybe there need add a
name:
prefix?helm-charts/charts/risingwave/templates/frontend-deploy.yaml
Line 50 in 3cb638b
The text was updated successfully, but these errors were encountered: