Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance lost after using BTreeMap for WITH properties #17139

Closed
yuhao-su opened this issue Jun 6, 2024 · 0 comments
Closed

Performance lost after using BTreeMap for WITH properties #17139

yuhao-su opened this issue Jun 6, 2024 · 0 comments
Labels
type/perf

Comments

@yuhao-su
Copy link
Contributor

yuhao-su commented Jun 6, 2024

After unify all WITH properties struct from HashMap to BTreeMap in #17137. The e2e test and e2e parallel test time increased a little, indicated some performance lost.

Interesting thing is the e2e_test/streaming got slower while they should not involve any WITH properties

After applying BTreeMap
https://buildkite.com/risingwavelabs/pull-request/builds/51250#018feaa9-b302-4b60-a237-74bbdfdfbb8e

Before applying BTreeMap
https://buildkite.com/risingwavelabs/pull-request/builds/51237#018fe93e-ea86-4e21-b900-8716cdcf164f
@github-actions github-actions bot added this to the release-1.10 milestone Jun 6, 2024
@fuyufjh fuyufjh removed this from the release-1.10 milestone Jul 10, 2024
@BugenZhao BugenZhao closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/perf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fuyufjh @BugenZhao @yuhao-su