Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove choice && check #2726

Open
hamirmahal opened this issue Mar 17, 2023 · 0 comments · May be fixed by #2727
Open

refactor: remove choice && check #2726

hamirmahal opened this issue Mar 17, 2023 · 0 comments · May be fixed by #2727

Comments

@hamirmahal
Copy link
Contributor

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[x] Other: Remove unnecessary `choice &&` check

Correct me if I'm mistaken, but I don't think the check for choice's truthiness, choice && choice === ..., adds anything.
@hamirmahal hamirmahal linked a pull request Mar 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove unnecessary choice &&s hamirmahal/vscode-live-server
1 participant
@hamirmahal