Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leader Attachments sometimes broken #170

Closed
riverwanderer opened this issue May 16, 2024 · 4 comments
Closed

Leader Attachments sometimes broken #170

riverwanderer opened this issue May 16, 2024 · 4 comments
Assignees
@riverwanderer
Labels
beta Report from a Beta release bug Something isn't working
Milestone
5.1.1

Comments

@riverwanderer
Copy link
Owner

Module V5.0.0beta9
Vassal V3.7.12
Scenario 320 Wagram - 6 July 1809 (Davout at Markgrafneusiedl)

Leader Casualty Check not offered -

e.g. Wagram test game, FT14 LCC not presented on Puthod.
@riverwanderer riverwanderer added bug Something isn't working beta Report from a Beta release Combat Assist labels May 16, 2024
@riverwanderer riverwanderer added this to the 5.0.0 milestone May 16, 2024
@riverwanderer riverwanderer self-assigned this May 16, 2024
@riverwanderer
Copy link
Owner Author

riverwanderer commented May 18, 2024 •
edited
Loading

LCC fix in #106.

There are other circumstances when broken Leader attachment would cause issues, such as card play validation & automation. This issue kept open as a placeholder.

@riverwanderer riverwanderer mentioned this issue May 18, 2024
Closed
@riverwanderer riverwanderer changed the title Leader Casualty Check not offered Leader Attachments sometimes broken May 18, 2024
@riverwanderer riverwanderer reopened this May 18, 2024
@riverwanderer riverwanderer modified the milestones: 5.0.0, 5.0.1 May 18, 2024
@riverwanderer
Copy link
Owner Author

Appears linked to Vassal issue #13315.

@riverwanderer
Copy link
Owner Author

.. but also has a further root case. See Vassal issue #13447. Workaround from Vassal 3.7.13 is to always re-apply ghkAttachLeaders via the optionVassalPostRefreshGHK when refreshing.

@riverwanderer
Copy link
Owner Author

Fixed with resolution to Vassal issue #13447 and associated remedial refresh in CCN 5.1.0beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riverwanderer riverwanderer

Labels
beta Report from a Beta release bug Something isn't working
Projects
CCNap 5
Status: Done
Milestone
5.1.1
Development

No branches or pull requests
1 participant
@riverwanderer