Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: git registries #123

Merged
merged 1 commit into from
Mar 6, 2024
Merged

feat: git registries #123

merged 1 commit into from
Mar 6, 2024

Conversation

NathanFlurry
Copy link
Member

Fixes OGBE-17

@linear Linear
Copy link

linear bot commented Mar 6, 2024

OGBE-17 Module registries

This was referenced Mar 6, 2024
Merged
Merged
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Mar 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

MasterPtato
MasterPtato requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NathanFlurry do you think it would be better to have a gen folder somewhere outside of the project like deno does with its dependency downloads?

src/cli/commands/db.ts Outdated Show resolved Hide resolved
@NathanFlurry Graphite App
Copy link
Member Author

@NathanFlurry do you think it would be better to have a gen folder somewhere outside of the project like deno does with its dependency downloads?

probably at some point, but i want to keep it simple as hell for now. we're not going to have the level of module sprawl that npm has. (knock on wood)

@NathanFlurry NathanFlurry force-pushed the 03-05-fix_print_err_when_failing_to_start_postgres_container branch from 3d59355 to 2121eb4 Compare March 6, 2024 05:48
This was referenced Mar 6, 2024
Merged
Merged
This was referenced Mar 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@NathanFlurry NathanFlurry force-pushed the 03-05-fix_print_err_when_failing_to_start_postgres_container branch from 2121eb4 to e43eb97 Compare March 6, 2024 07:46
@NathanFlurry NathanFlurry force-pushed the 03-05-feat_git_registries branch 2 times, most recently from 2e8a41b to 7325275 Compare March 6, 2024 07:47
@NathanFlurry NathanFlurry mentioned this pull request Mar 6, 2024
Merged
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Mar 6, 2024 •
edited
Loading

Merge activity

  • Mar 6, 4:26 AM EST: @NathanFlurry started a stack merge that includes this pull request via Graphite.
  • Mar 6, 4:31 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 6, 4:32 AM EST: @NathanFlurry merged this pull request with Graphite.

@NathanFlurry NathanFlurry force-pushed the 03-05-fix_print_err_when_failing_to_start_postgres_container branch from e43eb97 to bc4d717 Compare March 6, 2024 09:27
@NathanFlurry NathanFlurry changed the base branch from 03-05-fix_print_err_when_failing_to_start_postgres_container to main March 6, 2024 09:29
@NathanFlurry NathanFlurry merged commit fcfc3bd into main Mar 6, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

@ABCxFF ABCxFF Awaiting requested review from ABCxFF

@Blckbrry-Pi Blckbrry-Pi Awaiting requested review from Blckbrry-Pi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NathanFlurry @MasterPtato