Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add operation to list all clusters #717

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

AngelOnFira
Copy link
Member

Changes

Copy link
Contributor

graphite-app bot commented Apr 19, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

AngelOnFira commented Apr 19, 2024

@AngelOnFira AngelOnFira mentioned this pull request Apr 19, 2024
@AngelOnFira AngelOnFira marked this pull request as ready for review April 19, 2024 04:11
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from 27f1de1 to 26911c8 Compare April 19, 2024 05:27
@AngelOnFira AngelOnFira force-pushed the 04-09-docs_fern_installation_instructions_for_script branch from d4ec784 to 1152d87 Compare April 19, 2024 13:06
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from 26911c8 to 081ed24 Compare April 19, 2024 13:06
@AngelOnFira AngelOnFira force-pushed the 04-09-docs_fern_installation_instructions_for_script branch from 1152d87 to e07ddb3 Compare April 19, 2024 13:34
@AngelOnFira AngelOnFira changed the base branch from 04-09-docs_fern_installation_instructions_for_script to main April 19, 2024 13:49
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch 4 times, most recently from ed5d04e to f2343ed Compare April 19, 2024 15:59
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this operation going to be used for?

Copy link
Member Author

What is this operation going to be used for?

It seems like the way to go is to do as much on the api consumer (bolt in this case) as possible. As such, there needs to be a way to convert from the name_id that is given from the CLI to a cluster_id, and instead of making 2 api calls, it would be better to make a single one that gets all the clusters, and let the client find the one it needs itself.

I was chatting with @NathanFlurry about this, and the idea is putting as much of the logic on the client side as possible. But if this doesn't seem right, I can check out a different way of going about it.

Copy link
Contributor

graphite-app bot commented Apr 21, 2024

Merge activity

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from 4bdfefc to 1f4b169 Compare April 21, 2024 00:18
@graphite-app graphite-app bot merged commit 1f4b169 into main Apr 21, 2024
9 of 10 checks passed
@graphite-app graphite-app bot deleted the 04-19-feat_add_operation_to_list_all_clusters branch April 21, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants