chore(k3d): disable volumes if using use_local_repo #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NathanFlurry and the rest of your teammates on |
This was referenced Jun 26, 2024
MasterPtato
requested changes
Jun 27, 2024
Comment on lines
276
to
278
| if let ns::KubernetesProvider::K3d { use_local_repo } = &config.kubernetes.provider { | ||
| vars.insert("k3d_use_local_repo".into(), json!(use_local_repo)); | ||
| } |
There was a problem hiding this comment.
Should this also insert the var with value false if use_local_repo isn't set? The var in terraform isnt marked as optional
NathanFlurry
force-pushed
the
06-26-chore_k3d_disable_volumes_if_using_use_local_repo
branch
from
9dd22c2
to
4fb7920
Compare
This was referenced Jul 2, 2024
MasterPtato
approved these changes
Jul 3, 2024
This was referenced Jul 3, 2024
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
NathanFlurry
force-pushed
the
06-26-chore_k3d_disable_volumes_if_using_use_local_repo
branch
from
4fb7920
to
c375325
Compare
graphite-app
bot
deleted the
06-26-chore_k3d_disable_volumes_if_using_use_local_repo
branch
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes