Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with degree-Rips for pseudometric spaces #167

Open
mlesnick opened this issue Aug 4, 2022 · 0 comments
Open

issue with degree-Rips for pseudometric spaces #167

mlesnick opened this issue Aug 4, 2022 · 0 comments

Comments

@mlesnick
Copy link
Contributor

mlesnick commented Aug 4, 2022

I was looking over the degree-Rips code and realized that it doesn't properly handle pseudometric spaces.

Specifically, the function BifiltrationData::generate_vertex_multigrades always adds a generator at index ((0,0) for each vertex, but for pseudometric spaces, that's not what we want. We need to count the vertices of distance 0 to each vertex. The effect is that there may be a generator at (d,0) for d>0, but RIVET will remove this via a call to BifiltrationData::update_grades and report that there is a generator at (0,0).

This is technically a bug, since the documentation (Section 8.3) says that RIVET accepts a distance matrix with some off-diagonal entries equal to zero. It could be an issue, e.g., for genetic data, where you might well see two copies of the same genome. In practice, when one visualizes degree-Rips bifiltrations in RIVET, one doesn't not worry so much about what is happening at r=0, which is why this didn't get noticed sooner. But it if course still needs to be fixed.

Fixing this may require some care, because of the way this code interfaces with the code for coarsening, but I will take care of it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant