Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize keeping vars with lower addrs when deciding which overlapping var to kill #167

Open
thestr4ng3r opened this issue Oct 16, 2020 · 3 comments
Open

Prioritize keeping vars with lower addrs when deciding which overlapping var to kill #167

thestr4ng3r opened this issue Oct 16, 2020 · 3 comments
Assignees
@thestr4ng3r @kd1729
Labels
good first issue Good for newcomers test-required

Comments

@thestr4ng3r
Copy link
Member

thestr4ng3r commented Oct 16, 2020 •
edited

Depending on what types are assigned to variables in Rizin, they might overlap depending on their size. This is not supported by the decompiler and it has to remove some if such a case is detected.
When doing this, rz-ghidra should prefer keeping the variables that have the lower base address.
@thestr4ng3r thestr4ng3r self-assigned this Oct 16, 2020
@XVilka
Copy link
Member

XVilka commented Jan 21, 2021

Please provide a test case.

@XVilka XVilka added the good first issue Good for newcomers label Jan 21, 2021
@XVilka XVilka added RSoC and removed RSoC labels Mar 5, 2021
@XVilka XVilka removed the RSoC label Jul 2, 2022
@kd1729
Copy link

kd1729 commented Mar 2, 2024

Hi @thestr4ng3r I want to solve this issue as my microtask in GSOC'24

@XVilka
Copy link
Member

XVilka commented Mar 2, 2024

@kd1729 sure, go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thestr4ng3r thestr4ng3r

@kd1729 kd1729

Labels
good first issue Good for newcomers test-required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XVilka @thestr4ng3r @kd1729