Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RzAnalysisOp.val won't get set #13

Closed
Rot127 opened this issue Aug 13, 2021 · 3 comments · Fixed by rizinorg/rizin#1614 or #16
Closed

RzAnalysisOp.val won't get set #13

Rot127 opened this issue Aug 13, 2021 · 3 comments · Fixed by rizinorg/rizin#1614 or #16
Labels
enhancement New feature or request

Comments

@Rot127
Copy link
Member

Rot127 commented Aug 13, 2021 •
edited

The analysis code does not set the RzAnalysisOp.val member. This is especially problematic, because the val member is used when one uses /ai to search for immediate operands.

It should be set to the immediate value of the instruction.
@Rot127 Rot127 added the enhancement New feature or request label Aug 13, 2021
@Rot127 Rot127 mentioned this issue Aug 13, 2021
Open
@Rot127
Copy link
Member Author

Rot127 commented Aug 13, 2021 •
edited

The RzAnalysisOp.val is an ut64. Since Hexagons immediate values are sometimes signed, we probably should change this to an st128 (if this type even exists in rizin). casting them have to be enough.

@Rot127 Rot127 added rizin Involves changes to the rizin core source and removed rizin Involves changes to the rizin core source labels Aug 13, 2021
@XVilka
Copy link
Member

XVilka commented Aug 13, 2021

There is some support for big nums, see librz/include/rz_util/rz_big.h and librz/util/big*.c. Another possibility, is to always operate on bitvectors like in the new RZIL: https://github.com/rizinorg/rizin/pull/1451/files#diff-3b8dfdda14335ba07ec61139e6adec748233d1e5499c22900f30d07fddf7e1ed

@Rot127
Copy link
Member Author

Rot127 commented Aug 16, 2021

Just to mention it here: Some instructions have two immediate values. So RzAnalysisOp.val probably have to become an array.

@Rot127 Rot127 mentioned this issue Aug 17, 2021
Closed
4 tasks
@Rot127 Rot127 closed this as completed Aug 25, 2021
@Rot127 Rot127 mentioned this issue Sep 7, 2021
Merged
4 tasks
@Rot127 Rot127 mentioned this issue Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@XVilka @Rot127