Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit packet prefix if only one instruction is disassembled #17

Closed
Rot127 opened this issue Aug 17, 2021 · 1 comment · Fixed by #16 or rizinorg/rizin#1614
Closed

Omit packet prefix if only one instruction is disassembled #17

Rot127 opened this issue Aug 17, 2021 · 1 comment · Fixed by #16 or rizinorg/rizin#1614
Labels
enhancement New feature or request

Comments

@Rot127
Copy link
Member

Rot127 commented Aug 17, 2021

In case only one instruction is disassembled the packet prefix should be omitted.

[0x00005000]> pi 1
\ jump 0x1209c

should become

[0x00005000]> pi 1
jump 0x1209c

To do this we have to track somehow whether a whole block is disassembled or only one instruction.
Also see the discussion here: rizinorg/rizin#1338 (comment)
@Rot127 Rot127 added the enhancement New feature or request label Aug 17, 2021
@Rot127 Rot127 mentioned this issue Aug 17, 2021
Closed
@Rot127 Rot127 mentioned this issue Aug 26, 2021
Merged
@Rot127 Rot127 mentioned this issue Oct 14, 2021
Merged
4 tasks
@Rot127
Copy link
Member Author

Rot127 commented Nov 19, 2021

Currently the prefix is a "?". Since it does increase the complexity of the code, I would close this issue.

@Rot127 Rot127 closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Rot127