Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Zotero plugin Icons #9

Open
hydroEng opened this issue Sep 25, 2021 · 13 comments
Open

Feature request - Zotero plugin Icons #9

hydroEng opened this issue Sep 25, 2021 · 13 comments

Comments

@hydroEng
Copy link

Hi,

Thanks for this wonderful and modern icon theme for LO. Just wanted to request whether you would be willing to make a new icon set for the Zotero LibreOffice plugin. Many people rely on this across all operating systems, so it would be great if the icons fit in with the rest of the set. See current icons below:

image

Here is the github repo

https://github.com/zotero/zotero-libreoffice-integration

Thanks :)

@rizmut
Copy link
Owner

rizmut commented Sep 25, 2021

Thanks for opening the issue. It's up to Zotero developer to create a variant of Colibre style or completely switch to it. I can help draw the icon but of course the final decision is not on me. :)

@rizmut
Copy link
Owner

rizmut commented Sep 25, 2021

I have found this similar request as well: zotero/zotero-libreoffice-integration#43

@hydroEng
Copy link
Author

Ah okay, hopefully the devs will respond positively to your comment!

@hydroEng
Copy link
Author

Hello, was wondering if anyone picked this up? From what I understand from your link this probably won't be happening, I assume?

@raffaem
Copy link

raffaem commented Oct 8, 2022

I have found this similar request as well: zotero/zotero-libreoffice-integration#43

I have replied to you :)

If you can work on it, I will try to add it to the LibreOffice extension.

I have previously PR the Zotero LibreOffice extension :)

@rizmut
Copy link
Owner

rizmut commented Nov 5, 2022

HI I am working on this request. I hope also there will be dark variant support too since I will create two variants.

@raffaem
Copy link

raffaem commented Nov 9, 2022

Hi, this is now available on my fork

@rizmut
Copy link
Owner

rizmut commented Nov 11, 2022

Hi, this is now available on my fork

Nice, seems I can close this feature request from now.

@rizmut
Copy link
Owner

rizmut commented Nov 11, 2022

Hi, this is now available on my fork

Nice, thank you very much for your work

This is how it looked
image
image
image
image

@hydroEng
Copy link
Author

Would it be possible to provide a new icon set that works well in both light and dark mode, that can replace the current default one?

To be honest the main issue with the default theme is that it looks bad in dark mode (also looks kind of outdated).

Maybe if there is any interest from @rizmut for creating a singular set of icons, would the plugin maintainer be in principle interested in that?

@rizmut
Copy link
Owner

rizmut commented Nov 12, 2022

Would it be possible to provide a new icon set that works well in both light and dark mode, that can replace the current default one?

Unfortunately the answer is no, Colibre is not intended to be adaptive like that. So far it's Yaru's icon theme that has a similar vision, and I don't like that approach because it makes the icon thickness less consistent between the light and dark variants.

@hydroEng
Copy link
Author

Would it be possible to provide a new icon set that works well in both light and dark mode, that can replace the current default one?

Unfortunately the answer is no, Colibre is not intended to be adaptive like that. So far it's Yaru's icon theme that has a similar vision, and I don't like that approach because it makes the icon thickness less consistent between the light and dark variants.

Sorry to be annoying but, as it stands, your new theme works much better in dark mode than the zotero default.

image

I understand this might not follow standard adaptive design practices but all you would need to do would be to change the color of the last icon (the chain link) to something that works well in both dark and light mode.

If I ask the plugin maintainer whether they would be interested in upstreaming your light variant of the colibre icon theme if you make this change, would you be willing to update it?

@rizmut
Copy link
Owner

rizmut commented Jul 30, 2023

If I ask the plugin maintainer whether they would be interested in upstreaming your light variant of the colibre icon theme if you make this change, would you be willing to update it?

I have no intention to do so, anyone can do the task anyway if interested. Sorry for very late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants