Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Shortcuts for new top-level menu items #1058

Closed
craigo- opened this issue Mar 18, 2019 · 4 comments
Closed

Keyboard Shortcuts for new top-level menu items #1058

craigo- opened this issue Mar 18, 2019 · 4 comments
Assignees

Comments

@craigo-
Copy link

craigo- commented Mar 18, 2019

Notepad3 (64-bit) v5.19.316.1659 XpErImEnTaL

I noticed that the new menu items Language and Themes do not have keyboard shortcuts. Is there a reason for this? If not, might I suggest Alt+L and Alt+T respectively?

image

@RaiKoHoff
Copy link
Collaborator

Unfortunately, both "Hotkeys" are in use:

  • Alt+L : File -> Launch -> Open with...
  • Alt-T : toggles Settings -> Window -> Always On Top
    🤔

@craigo-
Copy link
Author

craigo- commented Mar 20, 2019

Hmmm. Tricky. On the one hand, I feel like the top-level menu items in any Windows application should have their respective keyboard shortcuts reserved. On the other, I know that Notepad3 has a past and current need for a lot of keyboard shortcuts (and I'm reluctant to mess with them too much, in case it annoys the user base)!

I toyed with the idea of using letters other than the first for the new top-level menus. You could use Alt+A for the "Language" menu, but there are no available options for the "Themes" menu (Alt+h, e, m, s are all in use).

How does the Notepad3 community feel about this?

Alt+L: Language menu
Alt+T: Themes menu
Ctrl+Alt+L: Open with...
Ctrl+Alt+Shift+T: Always On Top

Of course, this is all in the context of an experimental build. Should the Themes menu not go ahead, a simple solution would be to bind Alt+A to the "Language" menu and leave everything else alone.

@RaiKoHoff
Copy link
Collaborator

@craigo- : your suggestion is worth to think about - unfortunately, this question here is closely related to another question for @hpwamr :
What about other languages, which currently don't care about the "Alt+<Key>" Menu popup Accelerator-Key collisions.
So, for en-US and en-GB we can keep the combinations and think about @craigo-'s proposal,
for all other languages, we have to disable the "Alt+<Key>" for the menu items, which cause a collision 🤔

@hpwamr
Copy link
Collaborator

hpwamr commented Jun 1, 2019

The rearranging the Language and Themes menus is done.

Feel free to test the RC2 version: "Notepad3Portable_5.19.601.1002_RC2" or higher.
See "Notepad3 beta-channel access #1129" or download it from here Notepad3Portable

As far as I am concerned, this issue may be closed.... 🤔

@hpwamr hpwamr closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants