Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet mode is not enforced on refresh #93

Closed
jakery opened this issue Oct 27, 2016 · 2 comments · Fixed by #104
Closed

Quiet mode is not enforced on refresh #93

jakery opened this issue Oct 27, 2016 · 2 comments · Fixed by #104
Assignees
Milestone

Comments

@jakery
Copy link

jakery commented Oct 27, 2016

Using esw version 3.8.1, I am attempting to run quiet mode. This is correctly enforced upon first run of the command. However, when I change a file, and esw refreshes, quiet mode is no longer enforced; warnings are displayed.

Command:
node ./node_modules/eslint-watch/bin/esw -w --color --quiet --ignore-path ./.eslintignore

Initial output:
before

After touching Utility.js:
after

@rizowski
Copy link
Owner

Thanks for reporting this.

@rizowski
Copy link
Owner

@jakery Just an update to this, I remember when I first built the tool I made warnings show on watch because we had a ton of single/double quote warnings in files and we wanted to fix them eventually. I can see a case however where you would want to disable that.

I haven't been able to sit down to code out the fix. I did, however, read more into the cli.engine for eslint to see if they allowed for the quiet flag. I haven't seen anything like that over my light analysis. So a manual process for ignoring warnings in watch mode for eslint-watch may be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants