new_from_short_name falls back on Software::License::ShortName #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -194,7 +194,11 @@ my %short_name = ( | |||
|
|
|||
| Create a new L<Software::License> object from the license specified | |||
| with C<short_name>. Known short license names are C<GPL-*>, C<LGPL-*> , | |||
| C<Artistic> and C<Artistic-*> | |||
| C<Artistic> and C<Artistic-*>. If the short name is not know, this | |||
|
With some squashing, and correcting the typo noted above, this looks reasonable to me on first glance. |
|
No problem. I'll do this tomorrow. All the best |
|
Done. The typo is fixed and the commits were squashed. All the best |
|
Actutally, this PR was merged a while ago by rjbs. I don't know why this PR was not closed before. |
|
Hum, I messed up the above squash. I've now fixed everything but I cannot re-open this PR. I'm going to create another PR. Sorry about the mess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Previously,
new_from_short_nameworked using a set of pre-defined short names like GPL-1...Unfortunately, this means that this method failed when using a short name like
MIT.This patch fixes this behavior: when the passed short name is not known (say
Foo),new_from_short_nametries to load a class likeSoftware::License::Foo.I believe that this behavior makes more sense.
All the best