Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added xmlrpc request string as object property #13

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

enrico-sorcinelli
Copy link
Contributor

Hi,
this PR aims to add XML-RPC request string as object property _xmlrcp_request_as_string after the simple_request() method call.
In fact, if first argument of the method above isn't a RPC::XML::request object itself (so we can use as_string method), it seems there isn't a possibility to retrieve the string sent to the server.

@rjray rjray merged commit 68b3ab7 into rjray:master Jan 4, 2021
@rjray
Copy link
Owner

rjray commented Jan 4, 2021

Merged. I noted that you misspelled the property as _xmlrcp_request_as_string rather than _xmlrpc_request_as_string. I'll fix that.

@rjray
Copy link
Owner

rjray commented Jan 5, 2021

This has me looking at this code again after several years. I realize that your patch could lead to some memory issues if a person is (for example) streaming a really large file in a request. I'm going to add to your code so that this is controlled by a configuration parameter in RPC::XML::Client::new(). I hope that this will still meet your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants