Update wagtail imports #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 98.07% 98.26% +0.19%
==========================================
Files 88 89 +1
Lines 2855 2945 +90
==========================================
+ Hits 2800 2894 +94
+ Misses 55 51 -4
Continue to review full report at Codecov.
|
ababic
requested changes
Sep 5, 2020
There was a problem hiding this comment.
Thank you @danbentley. This is really helpful of you. Just spotted one small typo, but otherwise this is looking great. Thanks for the help :)
| from wagtail.wagtailimages import get_image_model_string | ||
| from wagtail.wagtailimages.edit_handlers import ImageChooserPanel | ||
| from wagtail.wagtailadmin.edit_handlers import FieldPanel, PageChooserPanel | ||
| from wagtail.iamges import get_image_model_string |
There was a problem hiding this comment.
Thanks! 😳
I've pushed an additional commit with the typo fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the documentation to match the module path changes made in Wagtail 2.0.
https://github.com/wagtail/wagtail/blob/882f8f3cf8ddd79c30e611a48882b309e90dad0c/docs/releases/2.0.rst#wagtail-module-path-updates
I left the reference to
wagtailcorein the2.1.2release notes since the module path was accurate at the time though happy to update that too.https://github.com/rkhleics/wagtailmenus/blob/master/docs/source/releases/2.1.2.rst
Additionally, I've fixed an issue in the hook example code. Happy to break out into a separate PR if you prefer.
Thanks!