Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out and improve common code in vimpager/vimcat #182

Open
rkitover opened this issue May 10, 2016 · 2 comments
Open

factor out and improve common code in vimpager/vimcat #182

rkitover opened this issue May 10, 2016 · 2 comments
Milestone

Comments

@rkitover
Copy link
Owner

As I was working on vimcat a couple days ago, I was thinking there are some things that both utilities do that we can factor out into inc/.

@rkitover rkitover added this to the 2.07beta1 milestone May 10, 2016
@lucc
Copy link
Collaborator

lucc commented May 10, 2016

Or we could merge both scripts into one.

Another idea which I tried a while back was to split vimcat into a shellscript and a vim script (like vimpager). The rationale behind this was that vimcat is either run from the repo, installed or bundled with the standalone vimpager, In the first two cases it is obvious that it need not be a mixed source script. And when it is extracted from vimpager it could just as well be extracted as a separate shell script and vim script. I will send a PR and you can look at the code. That will explain it best. (Need to rebase first and makefile changes/bundling is still missing)

@lucc
Copy link
Collaborator

lucc commented Jul 19, 2016

Part of this is done in #196.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants