read directly from the resource, no intermediate string #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses less memory, not requiring the entire resource contents in memory before reading - renamed to more clearly indicate what it does - there's nothing schema or norm specific about it - clojure.edn/read is safer than read-string regarding read-eval - the test provides an example of a more typical ensure-conforms use - from resources rather than Clojure source
avescodes
pushed a commit
that referenced
this pull request
Jul 10, 2015
…diate-string-slurp read directly from the resource, no intermediate string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before reading
load-schema-rsctoread-resourceto more clearly indicate what it doesclojure.edn/readis safer thanread-stringregardingread-evalensure-conformsuse