Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

flavor "host": reduce memory consumption by sharing systemd pages across pods #1849

Open
alban opened this issue Dec 8, 2015 · 5 comments
Open

Comments

@alban
Copy link
Member

alban commented Dec 8, 2015

Filed after #1788 (comment):

At the moment, rkt compiled with the flavor host copies the binaries systemd, systemd-journald, etc. in stage1 at each rkt run instead of relying on bind mounts or overlay fs. It means each binary in stage1 will have a different inode on each pod, and the memory will not be shared across pods. It is wasting memory when running several pods.

We should try to use bind mounts.

@jonboulle jonboulle added this to the vfuture milestone Jan 15, 2016
@jonboulle jonboulle modified the milestones: v1.3.0, vfuture Feb 4, 2016
@alban alban modified the milestones: v1.5.0, v1.3.0 Mar 31, 2016
@s-urbaniak s-urbaniak modified the milestones: v1.7.0, v1.5.0 Apr 28, 2016
@alban
Copy link
Member Author

alban commented Apr 28, 2016

@dgonyeo do you have an opinion about this?

@alban
Copy link
Member Author

alban commented Apr 28, 2016

This should be an issue only on distributions that use the "host" flavor, such as Debian and Fedora.

CoreOS Linux and the official releases don't use the "host" flavor.

@cgonyeo
Copy link
Member

cgonyeo commented Apr 28, 2016

Sounds like a reasonable thing to do. I haven't poked at the stage1 code at all, so I don't have much of an idea on what it would take to implement it.

@alban
Copy link
Member Author

alban commented May 23, 2016

The code that does the copy is in installAssets(). I guess that instead of using proj2aci.PrepareAssets(), this could use a new function that does bind mounts instead of copies.

@alban alban modified the milestones: v1.9.0, v1.7.0 May 23, 2016
@tmrts tmrts modified the milestones: v1.11.0, v1.9.0 Jun 23, 2016
@alban alban modified the milestones: v1+, v1.11.0 Jul 6, 2016
@alban
Copy link
Member Author

alban commented Jul 6, 2016

Low priority, moving to v1+

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants