-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arguments being passed are in incorrect order #75
Comments
I'll check that in the next couple of days. Thanks for reporting! |
So finally, I think this is the same issue as #69. That is, version |
well, not for me. I'm re-writing passport in a more functional less state driven, no callbacks kind of way. I just can't take it anymore. Almost done. |
Please keep us updated. Having a good less-hacky authentication solution for koa would be great! |
Hey, I've published my promise driven authentication strategy framework. it's called papers, I have a koa-papers as well, because as you know what it passes to middleware is a bit different. |
will you look at that, I just noticed that node 7 was just released. I believe you have to use node --harmony-async-await flag though |
Hi @reharik thanks for the update! I never really did active promotion for NPM modules, but hackernews and reddit could work to get some initial momentum. I did a quick peak into your code. I would recommend to run some linting tools. E.g. you have some inconsistency when using |
Hi, I have a login route and inside it I do
return koapassport.authenticate('local', function(err, user, info, status) {
when I log out the args ( on what should be a successful login ), user, info and status are all null, and err is equal to my user object.
I'm defining my local strategy just like in the examples. Not sure quite what's going on.
I've read through the source code for koa-passport and local-passport and don't see what's happening. I guess the next step for me is to dig into passport source call, because if I"m not mistaken you are internally handing the call back to the passport.authenticate method, so perhaps something has chnaged in there.
I'm using koa-passport 2.2.2
Thanks,
Raif
The text was updated successfully, but these errors were encountered: