Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL support #118

Closed
ledell opened this issue Nov 10, 2021 · 11 comments
Closed

Add GraphQL support #118

ledell opened this issue Nov 10, 2021 · 11 comments

Comments

@ledell
Copy link
Member

ledell commented Nov 10, 2021

Meetup will be deprecating the REST API and replacing it with GraphQL. The REST API will be deprecated at the end of 2021, and the GraphQL API is already active. Therefore, for this package to remain usable, we have to replace the guts. The ghql package could be useful.

Here’s the info on migrating from REST to GraphQL: https://www.meetup.com/api/migrating
More info about GraphQL: https://www.meetup.com/api/general

FYI: @GregSutcliffe @maelle @benubah @LucyMcGowan @cvitolo @jennybc @Athanasiamo @olgamie @RickPack @malcolmbarrett @brooklynbagel @hfrick

@ledell ledell pinned this issue Nov 10, 2021
@ledell
Copy link
Member Author

ledell commented Nov 12, 2021

@GregSutcliffe @maelle @benubah @LucyMcGowan @cvitolo @jennybc @Athanasiamo @olgamie @RickPack @malcolmbarrett @brooklynbagel @hfrick

We scheduled a meeting to discuss this on Weds, Nov 17th at 11am PT. If any of you want to join, give a thumbs up and I will send you the invite.

@drmowinckels
Copy link
Member

Its a little late for me in the evening, but keep me posted. I'd like to be involved as I rely on the pkg for the new website build.

@hfrick
Copy link
Member

hfrick commented Nov 15, 2021

got the invite 👍

@ledell
Copy link
Member Author

ledell commented Dec 28, 2021

Update: @schloerke is currently working on rewriting the internal query logic and updating the two most useful functions, get_events() and find_groups().

@jromanowska
Copy link

I can help with testing - let me know when.

@ledell
Copy link
Member Author

ledell commented Feb 20, 2022

@jromanowska Thank you! @benubah Please let @jromanowska how she can help, when you're ready.

@benubah
Copy link
Collaborator

benubah commented Feb 21, 2022

Just to let everyone know... I am working on rewriting the remaining functions. I have working drafts but will send a PR soon so we can start testing.

@benubah
Copy link
Collaborator

benubah commented Apr 4, 2022

The work (plus testing) is ongoing here: #138

@RickPack
Copy link
Collaborator

RickPack commented Apr 4, 2022

Thank you, @benubah!

@frederikho
Copy link

Great to see that this package is maintained and that the GraphQL support is being added! When can we expect the updates to be merged into the main branch?

@ledell
Copy link
Member Author

ledell commented Apr 26, 2022

@frederikho I just merged into master. Please try it out if you can! We would really appreciate feedback. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants