Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails for DBI forwarder #4

Closed
Skywalker25 opened this issue Nov 19, 2022 · 6 comments
Closed

Build fails for DBI forwarder #4

Skywalker25 opened this issue Nov 19, 2022 · 6 comments
Labels
upstream Issue needs looking at by an upstream project dependency.

Comments

@Skywalker25
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.
nstool fails to extract the ncap from a NRO and exits the process (DBI.nro)

To Reproduce
Steps to reproduce the behavior:

  1. PIP Install nton
  2. run cmd nton build --sdmc "/switch/DBI.nro" PATH/TO/NRO/DBI.nro
  3. program exits while trying to extract the ncap from nro.

Expected behavior
A clear and concise description of what you expected to happen.

Ideally the program should skip the extract and create a new ncap but it seems it's an issue with nstool and not nton.
A new cmd option should be added to skip the extract and create a new control.ncap for those troublesome nros.

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot_20221118_060601

Additional context
Add any other context about the problem here.

@rlaphoenix rlaphoenix added the bug Something isn't working label Nov 19, 2022
@rlaphoenix
Copy link
Owner

Well I can see it's actually failing at the nstool verification call, not specifically the extraction call. However, it is also failing at that. We should probably make this issue on nstool.

@rlaphoenix
Copy link
Owner

I've added in master two new CLI flags, --no-verify and --craft-nacp. --no-verify will skip verification and --craft-nacp will create a new nacp instead of trying to extract one. There's already --icon for putting a manual icon in case of icon extraction failure, so no need for anything new there.

I'm considering these temporary/last-resort flags though and might not keep them. I might not even bring them to a new stable release, I will see what the nstool guy says in the Issue, jakcron/nstool#86 and if a proper solution can be ironed out I might just remove these arguments.

This project's main goal is to be safety-first. Having flags like these is just bad practice. However, I understand that right now without these flags there's no way to make forwarders for at least one NRO (probably more).

@rlaphoenix rlaphoenix added upstream Issue needs looking at by an upstream project dependency. and removed bug Something isn't working labels Nov 19, 2022
@rlaphoenix
Copy link
Owner

jakcron seems to indicate that it's a relatively simple fix, therefore I likely won't be pushing these flags to a stable release. I will keep them in master for now until a fix is out, at which those commits will be deleted and the fixed stable or pre-release will be advised to be used.

@rlaphoenix
Copy link
Owner

I've moved those new flags to nstool-workarounds branch.

@jakcron
Copy link

jakcron commented Dec 5, 2022

Please try with NSTool 1.6.6

@rlaphoenix
Copy link
Owner

Fixed if you use nstool v1.6.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue needs looking at by an upstream project dependency.
Projects
None yet
Development

No branches or pull requests

3 participants