Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https for external resources #34

Open
AlbertoDiazC opened this issue Feb 10, 2015 · 4 comments
Open

use https for external resources #34

AlbertoDiazC opened this issue Feb 10, 2015 · 4 comments

Comments

@AlbertoDiazC
Copy link

Change
src="//cdnjs.cloudflare.com/ajax/libs/d3/3.0.1/d3.v3.min.js"
src="//cdnjs.cloudflare.com/ajax/libs/jquery/1.11.0/jquery.min.js"
for
src="https://cdnjs.cloudflare.com/ajax/libs/d3/3.0.1/d3.v3.min.js"
src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.0/jquery.min.js"

@MACscr
Copy link

MACscr commented Aug 6, 2015

Huh? I dont think you understand that by using //, it uses whatever http or https you are using. // is the correct way to do things.

@lkraav
Copy link

lkraav commented Aug 6, 2015

@MACscr is correct, this is a non-issue

@AlbertoDiazC
Copy link
Author

The point is force the use of https, as cloudflare support it. If plain http is used, the door is open for XSS attacks, which would fail in the https scenario.

@MACscr
Copy link

MACscr commented Aug 7, 2015

Why in the world would you make this script open to the public where XSS would even be an issue? https doesn't automatically solve XSS. Here is crazy idea, simply adjust the code for your individual need. Its a single file. Not hard. https is not always needed and it's senseless to have it enabled all the time. You can even put the js files local if you really want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants