Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of the slug size #6

Closed
rlespinasse opened this issue Mar 7, 2022 · 4 comments · Fixed by #7
Closed

Enable configuration of the slug size #6

rlespinasse opened this issue Mar 7, 2022 · 4 comments · Fixed by #7
Assignees
Labels
enhancement New feature or request released

Comments

@rlespinasse
Copy link
Owner

rlespinasse commented Mar 7, 2022

Currently limited to 63 characters, with an option, we could define another limit or no limit at all.

- uses: rlespinasse/slugify-value@v1
   with:
     key: KEY_NAME
     value: value_to_slugify
     slug-maxlength: 63
     # or
     slug-maxlength: nolimit

Related to rlespinasse/github-slug-action#87

@nkuehn
Copy link

nkuehn commented Mar 8, 2022

Thanks for following up in the right place, I obviously did not understand the nested structure of the actions.

On the proposal: if value is the name for the input, would the parameter maybe better be named slug-maxlength? It's not limiting the allowed length of the input, it's limiting the length of the output.

@rlespinasse
Copy link
Owner Author

@nkuehn Good catch 👍

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@nkuehn
Copy link

nkuehn commented Mar 21, 2022

wow, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants