Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify generator code with templating like logic ? #3

Closed
cderv opened this issue Nov 19, 2018 · 3 comments
Closed

Clarify generator code with templating like logic ? #3

cderv opened this issue Nov 19, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@cderv
Copy link
Collaborator

cderv commented Nov 19, 2018

I think it is not an heavy dependency and that maybe it could help clarify the generator code.
Clarifying the generation for R file could help for maintenance in the long run.
I'll try to look into it and PR something to see how it looks.

@RLesur
Copy link
Owner

RLesur commented Nov 20, 2018

No problem. Moreover, packages used in the generator do not create dependencies (they are ignored when the package is built).

@cderv cderv self-assigned this Nov 20, 2018
@cderv
Copy link
Collaborator Author

cderv commented Nov 24, 2018

I think I choose the wrong horse this morning... I believed it would simplified things but I am not so sure.
However, templating should be a good way to clarify the generation process for future maintenance. I'll leave this open.

@cderv cderv changed the title Use glue to clarify generator code Clarify generator code with templating like logic ? Nov 24, 2018
@cderv cderv added the enhancement New feature or request label Nov 25, 2018
@cderv
Copy link
Collaborator Author

cderv commented Apr 21, 2019

I close this for now as we are moving toward a new API in #40 and we do not generate code the same way

@cderv cderv closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants