Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't allow arbitrary tags #40

Closed
rlidwka opened this issue Jan 24, 2014 · 0 comments
Closed

don't allow arbitrary tags #40

rlidwka opened this issue Jan 24, 2014 · 0 comments

Comments

@rlidwka
Copy link
Owner

rlidwka commented Jan 24, 2014

A crafted request like this:

PUT /sinopia/user%2frepo HTTP/1.1
accept: application/json
content-type: application/json
content-length: 7
Connection: keep-alive

"0.6.0"

Can cause an invalid tag to be inserted, and cause issues in npm later.

Not a big deal unless you're using github dependencies with a package name that doesn't exist in repository.
@rlidwka rlidwka closed this as completed in 440f424 Feb 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rlidwka