Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file content search #6

Closed
BuZZ-dEE opened this issue May 12, 2020 · 4 comments
Closed

Implement file content search #6

BuZZ-dEE opened this issue May 12, 2020 · 4 comments

Comments

@BuZZ-dEE
Copy link
Contributor

Hi, thx for this great plugin, I really like it.

Could you please also implement file content search?

@rlivings39
Copy link
Owner

Seems doable. A few questions come to mind:

  • What would this do that the VSCode integrated search would do?

  • Do you have an fzf-based command in mind for doing the searching? What would the action be when you choose a search result? (open the associated file at the location?) I'm curious what you'd imagine the workflow to be

@BuZZ-dEE
Copy link
Contributor Author

BuZZ-dEE commented May 12, 2020

What would this do that the VSCode integrated search would do?

What do you mean? In My case I need this as a workaround for this bug. But I think it is good to have alternatives. ;)

Do you have an fzf-based command in mind for doing the searching?

Yes

What would the action be when you choose a search result? (open the associated file at the location?)

Just open the file in VSCode.

@rlivings39
Copy link
Owner

Thanks for the feedback. Any specific fzf command you'd want to run? Or should I try to cook something up? My bias would be to try and use ripgrep with fzf

@BuZZ-dEE
Copy link
Contributor Author

Yes, try to cook something using ripgrep. I already tried it and failed. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants