Remove Snapshotter #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjulian
force-pushed
the
remove-snapshotter
branch
from
764dbc5
to
6bb154c
Compare
krzentner
approved these changes
May 10, 2019
ryanjulian
force-pushed
the
remove-snapshotter
branch
from
6bb154c
to
ad4f9d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 94.05% 93.53% -0.52%
==========================================
Files 9 8 -1
Lines 370 325 -45
Branches 56 47 -9
==========================================
- Hits 348 304 -44
Misses 14 14
+ Partials 8 7 -1Continue to review full report at Codecov.
|
ryanjulian
force-pushed
the
remove-snapshotter
branch
2 times, most recently
from
e826551
to
99eed69
Compare
zhanpenghe
approved these changes
May 13, 2019
This was accidentally included during the import from rlworkgroup/garage. The Snapshotter is not part of the Logger API, so it doesn't really belong in this package.
ryanjulian
force-pushed
the
remove-snapshotter
branch
from
99eed69
to
66ab931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally included during the import from
rlworkgroup/garage.
The Snapshotter is not part of the Logger API, so it doesn't really
belong in this package.