Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conda from the setup scripts #444

Closed
amolchanov86 opened this issue Dec 20, 2018 · 5 comments · Fixed by #774
Closed

Remove conda from the setup scripts #444

amolchanov86 opened this issue Dec 20, 2018 · 5 comments · Fixed by #774
Assignees
Milestone

Comments

@amolchanov86
Copy link

As the title says, it would be better if the installation script would identify if the user already has anaconda running and simply add env to it, rather than installing miniconda and adding env there.
Right now, I hack it by providing a symbolic link from ~/miniconda/envs/garage to ~/anaconda2/envs/garage but the proper fix would be appropriate.

@amolchanov86 amolchanov86 added the bug Something isn't working label Dec 20, 2018
@ryanjulian ryanjulian added feature and removed bug Something isn't working labels Dec 20, 2018
@ryanjulian
Copy link
Member

This is actually intentional because we only test with miniconda2, and we don't want to provide installation routines for configurations which we don't test.

I didn't see it as a bug, since anaconda/miniconda can coexist peacefully.

What do you think about instead providing an arg to the setup script which allows the user to specify an existing conda to use (along with a warning message that we haven't tested your conda)?

@amolchanov86
Copy link
Author

I see. It is a workaround - I guess it will do the job. I mean it even works if I simply put a softlink :)
I am not sure why miniconda was a choice #1, I guess lightness was one factor.
The original rllab worked on anaconda, hence all the existing repos, i.e. from Chelsea and Tuomas are using anaconda (this is where I inherited the anaconda from as well).
Switching between them could indeed be done, it is just a matter of convenience for the user.

@ryanjulian
Copy link
Member

yeah--we have to keep it light to keep the CI fast.

if you are advanced enough to already have your own conda, then i think the switch will be okay. we will need to update the documentation.

@amolchanov86
Copy link
Author

Btw, one good update to documentation would be to add an explicit note that "if you are using anaconda, please follow the Manual installation" :)
I have just noticed that I shouldn't have used the express :)

@ryanjulian
Copy link
Member

Okay, let's make that part of the scope for this issue.

@ryanjulian ryanjulian changed the title Installation forces miniconda setup even when anaconda already present Add a setup parameter for a custom conda installation (and update documentation) Dec 21, 2018
@ryanjulian ryanjulian added this to the v2019.06 milestone Jun 20, 2019
@ryanjulian ryanjulian changed the title Add a setup parameter for a custom conda installation (and update documentation) Remove conda from the setup scripts Jun 21, 2019
@ryanjulian ryanjulian self-assigned this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants