Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install tensorflow out of the box #80

Closed
ryanjulian opened this issue Jun 14, 2018 · 5 comments
Closed

Install tensorflow out of the box #80

ryanjulian opened this issue Jun 14, 2018 · 5 comments

Comments

@ryanjulian
Copy link
Member

We can install tensorflow-cpu in all envs so that garage works out of the box. Those seeking GPU support can easily pip uninstall -y tensorflow and pip install tensorflow_gpu

@ryanjulian ryanjulian added this to the 2018.08 Release milestone Jul 27, 2018
@ghost ghost self-assigned this Aug 8, 2018
@ghost
Copy link

ghost commented Aug 8, 2018

I think this one will be solved by passing (or not) --tf-gpu to setup_linux.sh

@ryanjulian
Copy link
Member Author

The goal here is to install it without using any setup script, only the packaging tool (conda/environment.yml now, pip/setup.py later).

@ghost
Copy link

ghost commented Aug 10, 2018

I can add vanilla tensorflow to environment.yml. As we mentioned in #251, the setup script removes both flavors of TF to make sure the desired flavor is correctly installed, so it won't be a problem to add TF to the environment file.
If we remove the script in the future, we can follow the procedure you describe in the body of the issue.

@ryanjulian
Copy link
Member Author

Yeah please add tensorflow==1.9.0 to environment.yml, because it can be installed on all machines. For specializations (i.e. GPU), we can remove it and reinstall the special version.

@ghost
Copy link

ghost commented Aug 20, 2018

Closed with #279

@ghost ghost closed this as completed Aug 20, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant