Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SPI params bcm_DC, bcm_RST in favour of gpio_DC, gpio_RST #2

Closed
rm-hull opened this issue Jan 12, 2017 · 1 comment · Fixed by #50
Closed

Deprecate SPI params bcm_DC, bcm_RST in favour of gpio_DC, gpio_RST #2

rm-hull opened this issue Jan 12, 2017 · 1 comment · Fixed by #50
Assignees
@thijstriemstra

Comments

@rm-hull
Copy link
Owner

rm-hull commented Jan 12, 2017 •
edited

See https://github.com/rm-hull/luma.core/blob/master/luma/core/serial.py#L96

bcm is shorthand for 'broadcom' pin assignment, and is specific to RPi implementations, whereas gpio is a more general term, and should be used if ever a generic GPIO library replaces RPi.GPIO
@thijstriemstra
Copy link
Collaborator

perhaps we could use python's DeprecationWarning here

@thijstriemstra thijstriemstra mentioned this issue Mar 13, 2017
Merged
This was referenced Mar 13, 2017
Merged
Closed
@rm-hull rm-hull mentioned this issue Mar 15, 2017
Merged
@ameel ameel mentioned this issue Jul 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thijstriemstra thijstriemstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate spi params rm-hull/luma.core
2 participants
@thijstriemstra @rm-hull