Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope_and_collect should return results in order of submission #29

Closed
stepancheg opened this issue Jan 26, 2024 · 2 comments
Closed

scope_and_collect should return results in order of submission #29

stepancheg opened this issue Jan 26, 2024 · 2 comments

Comments

@stepancheg
Copy link

scope_and_collect function uses FuturesUnordered under the hood, so it returns futures in no order.

Unordered makes sense when we handle stream, but in collect operation it makes little sense and add complexity on caller side.

(Also scope_and_collect does not document that it returns results unordered).

@stepancheg stepancheg changed the title scope_and_collect should return futures in order scope_and_collect should return results in order of submission Jan 26, 2024
@rmanoka
Copy link
Owner

rmanoka commented Jan 26, 2024

This has been fixed in master, and should be released soon.

@rmanoka
Copy link
Owner

rmanoka commented Feb 8, 2024

Done in 0.9.0

@rmanoka rmanoka closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants