Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.4 #84

Closed
gerciljunio opened this issue Jan 28, 2017 · 5 comments
Closed

Laravel 5.4 #84

gerciljunio opened this issue Jan 28, 2017 · 5 comments
Assignees
Milestone

Comments

@gerciljunio
Copy link

Hello, do you have any plans to adapt to laravel 5.4? I was updating my system and found an error in LaravelJsLocalizationServiceProvider.php on line 67, I believe that is why the share method was removed in the latest version of laravel. Thanks!

@rmariuzzo
Copy link
Owner

Hey @gerciljunio! Yes, there's a pending PR for 5.4 support, I will do my best to merge today or by tomorrow.

@rmariuzzo rmariuzzo self-assigned this Jan 28, 2017
@joelcuevas
Copy link

joelcuevas commented Jan 31, 2017

How about supporting the new json files?

https://laravel.com/docs/5.4/localization#using-translation-strings-as-keys

C.C. @MCMatters. 😉

@antonkomarev
Copy link
Collaborator

antonkomarev commented Feb 1, 2017

@joelcuevas this planned for future releases. Feel free to add PR for it! :}

@rmariuzzo
Copy link
Owner

@gerciljunio I have merged this: #83 which add Laravel 5.4 support. I'm now writing proper tests that match Laravel 5.4. If it all works, I'm releasing it today.

@rmariuzzo
Copy link
Owner

Quick update: I'm tracking the addition of Laravel 5.4 tests here: #86

@rmariuzzo rmariuzzo modified the milestone: 1.4.0 Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants