-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 5.4 #84
Comments
Hey @gerciljunio! Yes, there's a pending PR for 5.4 support, I will do my best to merge today or by tomorrow. |
How about supporting the new json files? https://laravel.com/docs/5.4/localization#using-translation-strings-as-keys C.C. @MCMatters. 😉 |
@joelcuevas this planned for future releases. Feel free to add PR for it! :} |
@gerciljunio I have merged this: #83 which add Laravel 5.4 support. I'm now writing proper tests that match Laravel 5.4. If it all works, I'm releasing it today. |
Quick update: I'm tracking the addition of Laravel 5.4 tests here: #86 |
Hello, do you have any plans to adapt to laravel 5.4? I was updating my system and found an error in LaravelJsLocalizationServiceProvider.php on line 67, I believe that is why the share method was removed in the latest version of laravel. Thanks!
The text was updated successfully, but these errors were encountered: