Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup requirements #268

Closed
devfox-se opened this issue Jan 28, 2023 · 1 comment · Fixed by #274
Closed

Cleanup requirements #268

devfox-se opened this issue Jan 28, 2023 · 1 comment · Fixed by #274

Comments

@devfox-se
Copy link

Currently looking into the requirements that come along the package

https://github.com/rmax/scrapy-redis/blob/master/requirements.txt

scrapy>=2.0
redis>=4.0
six>=1.15
coverage
flake8
mock
pytest
tox
pytest-cov

these packages are completly uncecessary to perform the main package. I believe it is a good idea to get rid of them to not make the projects that rely on scrapy-redis filled with unnecessary packages

coverage
flake8
mock
pytest
tox
pytest-cov
@rmax
Copy link
Owner

rmax commented Jan 31, 2023

You are right, there is a mix with requirements, ideally these should go to requirements-test.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants