Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSimple Plugin not removing dns challange #548

Closed
jamessiuda1 opened this issue May 3, 2024 · 3 comments
Closed

DNSimple Plugin not removing dns challange #548

jamessiuda1 opened this issue May 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jamessiuda1
Copy link

posh acme is working great for us but it doesn't remove the txt record after the certificate is issued. Looking in debug mode it's stating the record does not exist, but it's still left after posh-acme is done running. Is this a bug with the plugin?

VERBOSE: Unpublishing challenge for Domain testing.example.com with Token TkpiNJXUMbszHlI9vdjRJ1N4ROJJYkG277q8EwpBg5s using Plugin DNSimple and DnsAlias ''.
DEBUG: Loading PAAccount list from disk
DEBUG: Calling DNSimple plugin to remove _acme-challenge.testing.example.com TXT with value Wgya1aoWyRSBcpztFdj1NEWzM0gUvOLEMzqk1VsIDPA
VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
VERBOSE: Received HTTP/1.1 response of content type application/json of unknown size
VERBOSE: Content encoding: utf-8
DEBUG: Found account 87989
DEBUG: Found zone example.com
VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
VERBOSE: Received HTTP/1.1 response of content type application/json of unknown size
VERBOSE: Content encoding: utf-8
DEBUG: Record _acme-challenge.testing.example.com with value Wgya1aoWyRSBcpztFdj1NEWzM0gUvOLEMzqk1VsIDPA doesn't exist. Nothing to do.

@rmbolger rmbolger self-assigned this May 3, 2024
@rmbolger rmbolger added the bug Something isn't working label May 3, 2024
@rmbolger
Copy link
Owner

rmbolger commented May 3, 2024

Hey @jamessiuda1, thanks for reaching out. It may very well be a bug. I'll have to brush off my account and do some testing.

@rmbolger
Copy link
Owner

rmbolger commented May 4, 2024

Bug confirmed. Not sure if the API changed or it has always been this way. But the code that was looking for the existing record needed to look for the TXT value with quotes around it and it hadn't been. I should have a basic fix committed to the main branch shortly.

There are a few other improvements I may try and make to the plugin as well. So it may be another couple days before I push an updated release.

@rmbolger
Copy link
Owner

rmbolger commented May 4, 2024

Fix is now live in 4.23.0

@rmbolger rmbolger closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants