Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.3.9 gives an error whenever I try to navigate it using the tab & arrow keys. #904

Closed
casualfan opened this issue May 12, 2024 · 22 comments
Labels
bug Something isn't working

Comments

@casualfan
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

[e.g. Windows 10, Windows 11, Mac, Linux (State distribution)]

Log Files
Attach your Libation log file here.
The owning DataGridViewCell object has not been set.

at System.Windows.Forms.DataGridViewCell.DataGridViewCellAccessibleObject.get_ParentPrivate()
at System.Windows.Forms.DataGridViewCell.DataGridViewCellAccessibleObject.get_Bounds()
at System.Windows.Forms.DataGridViewCell.System.Windows.Forms.IKeyboardToolTip.GetNeighboringToolsRectangles()
at System.Windows.Forms.ToolTip.GetOptimalToolTipPosition(IKeyboardToolTip tool, Rectangle toolRectangle, Int32 width, Int32 height)
at System.Windows.Forms.ToolTip.ShowKeyboardToolTip(String text, IKeyboardToolTip tool, Int32 duration)
at System.Windows.Forms.KeyboardToolTipStateMachine.ShowToolTip(IKeyboardToolTip tool, ToolTip toolTip)
at System.Windows.Forms.KeyboardToolTipStateMachine.Transition(IKeyboardToolTip tool, ToolTip tooltip, SmEvent event)
at System.Windows.Forms.KeyboardToolTipStateMachine.Transit(SmEvent event, IKeyboardToolTip source)
at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)

@casualfan casualfan added the bug Something isn't working label May 12, 2024
@rmcrackan
Copy link
Owner

Thanks for the bug report. This looks related to a piece of code I touched recently so I assume I created a bug. I'm not able to make this happen on my computer though. Can you attach your latest log file? You can find it here: Libation > Settings > click "Open log folder"

@casualfan
Copy link
Author

is it a zip file?

@rmcrackan
Copy link
Owner

Yes

@casualfan
Copy link
Author

_Log202405.zip

@rmcrackan
Copy link
Owner

This is disturbing. I can't make it happen for me no matter what I do but I see in your logs that it happened to you 3 times within a few seconds. Has it happened again since then?

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

This is disturbing. I can't make it happen for me no matter what I do but I see in your logs that it happened to you 3 times within a few seconds. Has it happened again since then?

Perhaps something to do with the version of Windows being used? I'm using Windows 11 here. If by any chance he's on Windows 11 and you on Windows 10, might not show up on your end?

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

I just switched from 11.3.9 Chardonnay to 11.3.9 Classic, hit the tab key a few times, and got an error myself.

The owning DataGridViewCell object has not been set.

   at System.Windows.Forms.DataGridViewCell.DataGridViewCellAccessibleObject.get_ParentPrivate()
   at System.Windows.Forms.DataGridViewCell.DataGridViewCellAccessibleObject.get_Bounds()
   at System.Windows.Forms.ToolTip.ShowKeyboardToolTip(String text, IKeyboardToolTip tool, Int32 duration)
   at System.Windows.Forms.KeyboardToolTipStateMachine.ShowToolTip(IKeyboardToolTip tool, ToolTip toolTip)
   at System.Windows.Forms.KeyboardToolTipStateMachine.Transition(IKeyboardToolTip tool, ToolTip tooltip, SmEvent event)
   at System.Windows.Forms.KeyboardToolTipStateMachine.Transit(SmEvent event, IKeyboardToolTip source)
   at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

OK, deleted the log files and started up again, started tabbing, and the error pops up as soon as I tab to the first "stoplight".

The owning DataGridViewCell object has not been set.

   at System.Windows.Forms.DataGridViewCell.DataGridViewCellAccessibleObject.get_ParentPrivate()
   at System.Windows.Forms.DataGridViewCell.DataGridViewCellAccessibleObject.get_Bounds()
   at System.Windows.Forms.ToolTip.ShowKeyboardToolTip(String text, IKeyboardToolTip tool, Int32 duration)
   at System.Windows.Forms.KeyboardToolTipStateMachine.ShowToolTip(IKeyboardToolTip tool, ToolTip toolTip)
   at System.Windows.Forms.KeyboardToolTipStateMachine.Transition(IKeyboardToolTip tool, ToolTip tooltip, SmEvent event)
   at System.Windows.Forms.KeyboardToolTipStateMachine.Transit(SmEvent event, IKeyboardToolTip source)
   at System.Windows.Forms.NativeWindow.Callback(HWND hWnd, MessageId msg, WPARAM wparam, LPARAM lparam)

_Log202405.zip

Edit:
Just to verify, I switched back to 11.3.9 Chardonnay, started tabbing, and no errors.

@rmcrackan
Copy link
Owner

Thanks. You both appear to have auto-scan enabled but I don't so I turned it on and restarted. I can now force this to happen if I use my arrow keys like crazy while the initial scan is happening. This is going to be a weird one...

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

Thanks. You both appear to have auto-scan enabled but I don't so I turned it on and restarted. I can now force this to happen if I use my arrow keys like crazy while the initial scan is happening. This is going to be a weird one...

If you mean the top setting here...

image

I did have that turned on. But i just now turned that off, and still getting the same error.

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

It also ONLY gives me an error when I tab to one of the "stoplights".

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

Recording.2024-05-13.132223.mp4

Here's a recording of it, right after starting Libation.

@rmcrackan
Copy link
Owner

Thank you so much for this. This is maddening. This error will happen only for the version which is built for the public. The way I run it for debugging, this error will not occur. So I can't reproduce it in a way that can be easily debugged. This is going to be a weird one.

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

Thank you so much for this. This is maddening. This error will happen only for the version which is built for the public. The way I run it for debugging, this error will not occur. So I can't reproduce it in a way that can be easily debugged. This is going to be a weird one.

Oh, fun. :-D

Well, at least you know where to look. I'm guessing something to do with the changes in the "stoplight" you did to make the text readers work in that field.

Edit:
UNLESS it's a bug that existed in previous releases that was never noticed. Do we know if this happened in previous releases or not?

@rmcrackan
Copy link
Owner

I'm guessing something to do with the changes in the "stoplight" you did to make the text readers work in that field.

Almost certainly. No good dead goes unpunished.

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

I'm guessing something to do with the changes in the "stoplight" you did to make the text readers work in that field.

Almost certainly. No good dead goes unpunished.

Just to be sure, I rolled back to Libation Classic 11.3.8, and no error on tabbing to the stoplights.

@rmcrackan rmcrackan reopened this May 13, 2024
@rmcrackan
Copy link
Owner

Fixed in the latest version 11.3.11 -- https://github.com/rmcrackan/Libation/releases/tag/v11.3.11

(I know I skipped 11.3.10. The explanation is technical and utterly boring.)

Please let me know if it still gives you errors. Thank you both for your patience and help!!

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

Fixed in the latest version 11.3.11 -- https://github.com/rmcrackan/Libation/releases/tag/v11.3.11

(I know I skipped 11.3.10. The explanation is technical and utterly boring.)

Please let me know if it still gives you errors. Thank you both for your patience and help!!

I can verify that it fixed it on my end, and Chardonnay also still working.

@rmcrackan
Copy link
Owner

Thanks for checking but Chardonnay is actually untouched in these last few releases. This is Classic only.

I'd love to retrofit Chardonnay for screen readers but I just don't have it in me. I'm trying hard to keep Classic as accessible as possible though.

@CharlieRussel
Copy link

Working correctly here. (But I hadn't updated for the last several, so never actually had it hit me. And yes, I'm on Classic.)

@CLHatch
Copy link
Contributor

CLHatch commented May 13, 2024

Thanks for checking but Chardonnay is actually untouched in these last few releases. This is Classic only.

I'd love to retrofit Chardonnay for screen readers but I just don't have it in me. I'm trying hard to keep Classic as accessible as possible though.

Yeah, had a feeling it was untouched, but figured best to verify the changes in Classic didn't break Chardonnay, in case there was some shared code there. :)

@rmcrackan
Copy link
Owner

Good call. There's actually an enormous amount of shared code. This happens to be in the thin purely UI part, which is separate between the 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants