DECam pupil plane not sampled well enough. #47
Milestone
Comments
|
I don't think my personal computer is on the bleeding latest GalSim master
code, but it currently only gives me that warning for DECam_pupil_128.fits,
and not for DECam_pupil_512.fits. (Former models pupil as 128 x 128 grid,
latter as 512 x 512.) These are for when you feed into Piff the pupil plane
image. The warning is probably actually working as intended; I don't
remember if it was always giving this warning, but I would not be surprised
if it was.
I'm going to dig into whether we can change the parameters to remove the
warning. Alternatively, we could just remove the 128 x 128 version.
…On Sun, Nov 27, 2016 at 11:28 PM Mike Jarvis ***@***.***> wrote:
The unit tests currently emit the warning:
UserWarning: Input pupil plane image may not be sampled well enough!
Consider increasing sampling by a factor 28.444900, and/or check PhaseScreenPSF outputs for signs of folding in real space.
@jmeyers314 <https://github.com/jmeyers314> @cpadavis
<https://github.com/cpadavis> I thought we solved this problem through
updates to GalSim, but I guess the changes haven't been propagated into
Piff yet. Unfortunately, I don't remember exactly what change needs to be
made in the Piff code. Could one of you take a look and see if we can fix
this behavior?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABsw5CjLL6pKbN5VK21GiS03pD51y1KIks5rCoKXgaJpZM4K9efh>
.
|
|
I get the warning for both files in Python 3, but only for DECam_pupil_128.fits in Python 2. |
rmjarvis
added a commit
that referenced
this issue
Mar 1, 2018
cpadavis
added a commit
that referenced
this issue
Apr 3, 2018
Report galsim version in setup.py Fix for python 3.6 Avoid deprecation warning about y_train_mean Speed up internals of gsobject_model using special GalSim underscore functions Trim down gsobject_model test suite when run from nosetests Speed up knn_interp test suite Fix the pupil image scales. Fixes #47 Don't do fit_report if logger=None (avoid warning in one of the test_optics tests) Speed up test_wcs.py Don't pop the type from config Use assume_a='pos' to avoid massive slowdown in scipy 1.0 Speed up test_pixel for nosetests runs Check for ra,dec in FITS header rather than rely on fitsio exception (which has changed recently) Ignore a warning from sklearn about lnsrch not converging Fix the calculation of nsvd typo Von-Karman kernel equal to 1 when distance equal to 0 fixed gp test add sugestion for distance==0 in von karman kernel atmosphere terms now get their own slots in star fit params some modifications to speed up fit_model fixing all them bugs Print exceptions that get caught. Make compatible with GalSim 2.0 version of project update to work with GalSim 2.0 Add LSSTDESC.Coord as a prereq in anticipation of GalSim 2.0 requirement Set version to 0.3 for master branch builds Fix dof from PixelGrid chisq calculation (reflux had it right) Don't switch to slow svd solution, despite scipy's warning. TODO: Need to think about this more. merging master changes back in more cleaning up interp may not have degenerate points. Also, do not interpolate for a second time a star that has already been interpolated in simplepsf added new tests
areshernandez
pushed a commit
that referenced
this issue
Aug 8, 2019
areshernandez
pushed a commit
that referenced
this issue
Aug 8, 2019
Report galsim version in setup.py Fix for python 3.6 Avoid deprecation warning about y_train_mean Speed up internals of gsobject_model using special GalSim underscore functions Trim down gsobject_model test suite when run from nosetests Speed up knn_interp test suite Fix the pupil image scales. Fixes #47 Don't do fit_report if logger=None (avoid warning in one of the test_optics tests) Speed up test_wcs.py Don't pop the type from config Use assume_a='pos' to avoid massive slowdown in scipy 1.0 Speed up test_pixel for nosetests runs Check for ra,dec in FITS header rather than rely on fitsio exception (which has changed recently) Ignore a warning from sklearn about lnsrch not converging Fix the calculation of nsvd typo Von-Karman kernel equal to 1 when distance equal to 0 fixed gp test add sugestion for distance==0 in von karman kernel atmosphere terms now get their own slots in star fit params some modifications to speed up fit_model fixing all them bugs Print exceptions that get caught. Make compatible with GalSim 2.0 version of project update to work with GalSim 2.0 Add LSSTDESC.Coord as a prereq in anticipation of GalSim 2.0 requirement Set version to 0.3 for master branch builds Fix dof from PixelGrid chisq calculation (reflux had it right) Don't switch to slow svd solution, despite scipy's warning. TODO: Need to think about this more. merging master changes back in more cleaning up interp may not have degenerate points. Also, do not interpolate for a second time a star that has already been interpolated in simplepsf added new tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The unit tests currently emit the warning:
@jmeyers314 @cpadavis I thought we (read Josh) solved this problem through updates to GalSim, but I guess the changes haven't been propagated into Piff yet. Unfortunately, I don't remember exactly what change needs to be made in the Piff code. Could one of you take a look and see if we can fix this behavior?
The text was updated successfully, but these errors were encountered: