Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get MNIST data and CData unit tests. #13

Open
rmlarose opened this issue Jun 15, 2019 · 0 comments
Open

Get MNIST data and CData unit tests. #13

rmlarose opened this issue Jun 15, 2019 · 0 comments
Assignees

Comments

@rmlarose
Copy link
Owner

@naezzell I think the input to LabeledCData in get_mnist_data is wrong. See TODO comment and please update when you can.

There are several unit tests failing in CData after some updates. (These should have been failing all along, the updates just revealed them.)

(1) The higher dimensional data example is not supported. The input data to any CData object must, as of know, be explicitly two-dimensional. I think this unit test should be removed. Thoughts?

(2) The train_test_split(...) unit test used to input one-dimensional data when creating a CData object, which is again nonsense. As such, the later checks are equally nonsense. Could you update this with sensible checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants