Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a FixerClient to seperate the HTTP infrastructure code. #14

Open
naveddeshmukh opened this issue Dec 1, 2018 · 1 comment
Open

Comments

@naveddeshmukh
Copy link

naveddeshmukh commented Dec 1, 2018

FixerClient will act as a wrapper around HttpClient, this will help in following

  • Allows to neatly implement a Singleton access to HttpClient.
  • Moves GetFixerUrl from Fixer Facade
  • Allows to expose a public method such as UseHttps() to support https connection Support https connections to API #11
@rmorrin
Copy link
Owner

rmorrin commented Dec 10, 2018

I like this idea 👍

I may not have much time to work on this with the holiday period coming up, but if you'd like to raise a PR, or even some sample code in here I'd be happy to take a look 😃

I'd like to keep the public API as small as possible and have the Fixer class manage all singleton access to this new FixerClient if possible, though I think this is what you're suggesting anyway!

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants